[llvm-commits] [llvm] r43988 - in /llvm/trunk: lib/Target/TargetCallingConv.td lib/Target/X86/X86CallingConv.td utils/TableGen/CallingConvEmitter.cpp

[Duncan Sands]

Hi Dale,

> Add CCAssignToStackABISizeAlign for convenience in
> dealing with types whose size & alignment are
> different on different subtargets.  Use it for x86 f80.

it's really not possible to have the size and alignment be optional
arguments to CCAssignToStack?

> +/// CCAssignToStackABISizeAlign - This action always matches: it assigns
> +/// the value to a stack slot of the ABISize and ABIAlignment for the type,
> +/// which may depend on the target or subtarget.
> +/// "ignored" is here because an empty arg list does not work.
> +class CCAssignToStackABISizeAlign<int ignored> : CCAction {

Maybe it should take the type as the argument?  Even if it's not used
it seems more logical to have CCAssignToStackABISizeAlign<f80>, since
the ABI size and alignment are for that type.

Ciao,

Duncan.