[llvm-commits] [llvm] r43918 - in /llvm/trunk/lib/Target/X86: X86RegisterInfo.cpp X86RegisterInfo.td

[Chris Lattner]

> URL: http://llvm.org/viewvc/llvm-project?rev=43918&view=rev
> Log:
> Rewrite Dwarf number handling per review comments.

Hi Dale,

I'm pretty uncomfortable with this, because it means that we're tying  
down the register order.
How about something like:

  if (Darwin32) {
   switch (RegNo) {
   case X86::AL: case X86::AH: case X86::AX:  return 0;
   case X86::EDI:  ...
  } else if (darwin64) {
   switch (RegNo) {
   ...
  } else {
  }

That way we don't break EH/debug info if registers are reordered or  
added in the future.

-Chris