[llvm-commits] [llvm] r43844 - in /llvm/trunk/lib/Target/X86: X86RegisterInfo.cpp X86RegisterInfo.td

[Anton Korobeynikov]

Dale,

> Complete conditionalization of Dwarf reg numbers.
This looks pretty hackish. The numbers used before were definitely
correct for x86-32/linux. I dunno about darwin, but it looks like
"turning everything on darwin to be default implementation" is not a
good approach. :)

And, if you need to conditionalize depending on target, table approach
(like in i386.h) will be definitely better, otherwise we'll end with
spaghetti-like code, when all supported targets will be in place.

-- 
With best regards, Anton Korobeynikov.

Faculty of Mathematics & Mechanics, Saint Petersburg State University.