[llvm-commits] [llvm] r43421 - in /llvm/trunk: include/llvm/Support/Alignment.h lib/CodeGen/SelectionDAG/DAGCombiner.cpp lib/CodeGen/SelectionDAG/LegalizeDAG.cpp lib/CodeGen/SelectionDAG/LegalizeDAGTypes.cpp

[Duncan Sands]

Hi Chris,

> instead of introducing a new header file for this, would it make  
> sense to merge into MathExtras.h?

I considered that but (1) it would pull in the rest of MathExtras,
for some compile time cost (maybe tiny) and (2) it would need to
have a "math" name (like pow2_gcd), which would make the use of it
more obscure.  Which is more readable:
	MinAlign(Align, Offset)
or
	pow2_gcd(Align, Offset)
?  That said, I'm happy to put it in MathExtras if you think that better.

Ciao,

Duncan.