[llvm-commits] [llvm] r43699 - in /llvm/trunk: lib/CodeGen/LiveVariables.cpp test/CodeGen/X86/2007-11-04-LiveVariablesBug.ll

[Evan Cheng]

Author: evancheng
Date: Sun Nov  4 21:11:55 2007
New Revision: 43699

URL: http://llvm.org/viewvc/llvm-project?rev=43699&view=rev
Log:
Handle cases where a register and one of its super-register are both marked as
defined on the same instruction. This fixes PR1767.

Added:
    llvm/trunk/test/CodeGen/X86/2007-11-04-LiveVariablesBug.ll
Modified:
    llvm/trunk/lib/CodeGen/LiveVariables.cpp

Modified: llvm/trunk/lib/CodeGen/LiveVariables.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/LiveVariables.cpp?rev=43699&r1=43698&r2=43699&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/LiveVariables.cpp (original)
+++ llvm/trunk/lib/CodeGen/LiveVariables.cpp Sun Nov  4 21:11:55 2007
@@ -203,7 +203,7 @@
                  RegInfo->isSuperRegister(IncomingReg, Reg) &&
                  MO.isKill())
         // A super-register kill already exists.
-        return true;
+        Found = true;
     }
   }
 
@@ -357,7 +357,9 @@
     } else if (PhysRegPartUse[Reg])
       // Add implicit use / kill to last partial use.
       addRegisterKilled(Reg, PhysRegPartUse[Reg], true);
-    else
+    else if (LastRef != MI)
+      // Defined, but not used. However, watch out for cases where a super-reg
+      // is also defined on the same MI.
       addRegisterDead(Reg, LastRef);
   }
 

Added: llvm/trunk/test/CodeGen/X86/2007-11-04-LiveVariablesBug.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/2007-11-04-LiveVariablesBug.ll?rev=43699&view=auto

==============================================================================
--- llvm/trunk/test/CodeGen/X86/2007-11-04-LiveVariablesBug.ll (added)
+++ llvm/trunk/test/CodeGen/X86/2007-11-04-LiveVariablesBug.ll Sun Nov  4 21:11:55 2007
@@ -0,0 +1,16 @@
+; RUN: llvm-as < %s | llc -mtriple=x86_64-unknown-linux-gnu
+; PR1767
+
+define void @xor_sse_2(i64 %bytes, i64* %p1, i64* %p2) {
+entry:
+        %p2_addr = alloca i64*          ; <i64**> [#uses=2]
+        %lines = alloca i32             ; <i32*> [#uses=2]
+        store i64* %p2, i64** %p2_addr, align 8
+        %tmp1 = lshr i64 %bytes, 8              ; <i64> [#uses=1]
+        %tmp12 = trunc i64 %tmp1 to i32         ; <i32> [#uses=2]
+        store i32 %tmp12, i32* %lines, align 4
+        %tmp6 = call i64* asm sideeffect "foo",
+"=r,=*r,=*r,r,0,1,2,~{dirflag},~{fpsr},~{flags},~{memory}"( i64** %p2_addr,
+i32* %lines, i64 256, i64* %p1, i64* %p2, i32 %tmp12 )              ; <i64*> [#uses=0]
+        ret void
+}