[llvm-commits] [llvm] r43326 - in /llvm/trunk: lib/Analysis/BasicAliasAnalysis.cpp test/Analysis/BasicAA/2007-10-24-ArgumentsGlobals.ll

[Chris Lattner]

On Oct 24, 2007, at 7:36 PM, Owen Anderson wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=43326&view=rev
> Log:
> Fix for PR1741.

Thanks Owen,  this is the proper fix, but it doesn't fix the whole  
problem:

> ====================================================================== 
> ========
> --- llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp (original)
> +++ llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp Wed Oct 24  
> 21:36:18 2007
> @@ -339,8 +339,9 @@
>
>          // Otherwise, nothing is known...
>        } else if (O1 != O2) {
> +        if (!isa<Argument>(O1))
> +          // If they are two different objects, we know that we  
> have no alias...
> +          return NoAlias;

Please change this to:

} else if (O1 != O2 && !isa<Argument>(O1) && !isa<Argument>(O2)) {
   return NoAlias;
}

Thanks for tackling this!

-Chris