[llvm-commits] [llvm] r42864 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/2007-10-10-EliminateMemCpy.ll

[Dale Johannesen]

On Oct 11, 2007, at 10:54 AM, Devang Patel wrote:

>
> On Oct 11, 2007, at 10:46 AM, Dale Johannesen wrote:
>
>> You aren't checking alignment when choosing the new pointer type.
>> Are you sure this works on machines that don't have misaligned  
>> load/store?
>>
>> In general memcpy handling is highly target specific.  I'd be wary  
>> of doing too
>> much in target-independent code, although I think the general idea  
>> here is OK.
>
> I'm expecting target specific code generator to  handle this if it  
> is handling unaligned memcpy.
> No ?

Might well work, I'm not sure what order things are done in.  Could  
you try it?  PPC for example.