[llvm-commits] [llvm] r41729 - in /llvm/trunk: include/llvm/CodeGen/LiveInterval.h include/llvm/CodeGen/LiveIntervalAnalysis.h lib/CodeGen/LiveInterval.cpp lib/CodeGen/LiveIntervalAnalysis.cpp lib/CodeGen/SimpleRegisterCoalescing.cpp

[Evan Cheng]

On Sep 5, 2007, at 5:05 PM, Chris Lattner wrote:

>
> On Sep 5, 2007, at 2:46 PM, Evan Cheng wrote:
>
>> Author: evancheng
>> Date: Wed Sep  5 16:46:51 2007
>> New Revision: 41729
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=41729&view=rev
>> Log:
>> Use pool allocator for all the VNInfo's to improve memory access
>> locality. This reduces coalescing time on siod Mac OS X PPC by 35%.
>> Also remove the back ptr from VNInfo to LiveInterval and other  
>> tweaks.
>
> Nice!  To verify, you *are* running the destructors on the VNInfo
> objects before you nuke the memory region, right?  Not destroying the
> VNInfo would cause the VNInfo::kills smallvector to leak memory.

Ugh, no. It's leaky like a broken lawn sprinkler. :-) I've fixed it  
with this patch:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20070903/053284.html

Evan

>
>
> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits