[llvm-commits] [llvm] r41721 - /llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp

Chris Lattner clattner at apple.com
Wed Sep 5 12:21:30 PDT 2007


On Sep 5, 2007, at 9:54 AM, Chuck Rose III wrote:

> Author: cfr
> Date: Wed Sep  5 11:54:38 2007
> New Revision: 41721
>
> URL: http://llvm.org/viewvc/llvm-project?rev=41721&view=rev
> Log:
> Added default parameters to GetElementPtrInstr constructor call.   
> Visual Studio 2k5 was getting confused and was unable to compile  
> it.  Suspected compiler error.

Hi Chuck,

The patch is fine, but please wrap it to fit in 80 columns, thanks!

-Chris

> Modified:
>     llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp
>
> Modified: llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ 
> Scalar/InstructionCombining.cpp?rev=41721&r1=41720&r2=41721&view=diff
>
> ====================================================================== 
> ========
> --- llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp  
> (original)
> +++ llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp Wed  
> Sep  5 11:54:38 2007
> @@ -7058,7 +7058,7 @@
>      // If we found a path from the src to dest, create the  
> getelementptr now.
>      if (SrcElTy == DstElTy) {
>        SmallVector<Value*, 8> Idxs(NumZeros+1, ZeroUInt);
> -      return new GetElementPtrInst(Src, Idxs.begin(), Idxs.end());
> +      return new GetElementPtrInst(Src, Idxs.begin(), Idxs.end(),  
> "", ((Instruction*) NULL));
>      }
>    }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list