[llvm-commits] [llvm] r41207 - in /llvm/trunk: include/llvm/Analysis/LoopInfo.h lib/Analysis/LoopInfo.cpp lib/Analysis/ScalarEvolution.cpp lib/Transforms/IPO/LoopExtractor.cpp lib/Transforms/Scalar/IndVarSimplify.cpp lib/Transforms/Scalar/LICM.cpp lib/Transforms/Scalar/LoopRotation.cpp lib/Transforms/Scalar/LoopUnswitch.cpp lib/Transforms/Utils/LCSSA.cpp lib/Transforms/Utils/LoopSimplify.cpp

[Chris Lattner]

On Aug 21, 2007, at 8:02 AM, Devang Patel wrote:

>>
>>> +void Loop::getExitingBlocks(SmallVector<BasicBlock*, 8>
>>> &ExitingBlocks) const {
>>>    std::vector<BasicBlock*> LoopBBs(block_begin(), block_end());
>>
>>> +void Loop::getExitBlocks(SmallVector<BasicBlock*, 8> &ExitBlocks)
>>> const {
>>>    std::vector<BasicBlock*> LoopBBs(block_begin(), block_end());
>>
>>> +void Loop::getUniqueExitBlocks(SmallVector<BasicBlock*, 8>
>>> &ExitBlocks) const {
>>>    std::vector<BasicBlock*> LoopBBs(block_begin(), block_end());
>>
>> Since you're in here, these are good candidates for (large)
>> smallvectors also.  Try making them SmallVector<, 128> for example.
>
> Yes. I intended to do it as a separate check-in.

Sounds great, thanks Devang!

-Chris