[llvm-commits] [llvm] r40829 - in /llvm/trunk/lib: Analysis/PostDominators.cpp VMCore/Dominators.cpp

[Chris Lattner]

Author: lattner
Date: Sat Aug  4 19:15:57 2007
New Revision: 40829

URL: http://llvm.org/viewvc/llvm-project?rev=40829&view=rev
Log:
Switch some std::sets to SmallPtrSet.  This speeds up
domtree by 10% and postdomtree by 17%

Modified:
    llvm/trunk/lib/Analysis/PostDominators.cpp
    llvm/trunk/lib/VMCore/Dominators.cpp

Modified: llvm/trunk/lib/Analysis/PostDominators.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/PostDominators.cpp?rev=40829&r1=40828&r2=40829&view=diff

==============================================================================
--- llvm/trunk/lib/Analysis/PostDominators.cpp (original)
+++ llvm/trunk/lib/Analysis/PostDominators.cpp Sat Aug  4 19:15:57 2007
@@ -29,7 +29,7 @@
 
 unsigned PostDominatorTree::DFSPass(BasicBlock *V, unsigned N) {
   std::vector<BasicBlock *> workStack;
-  std::set<BasicBlock *> visited;
+  SmallPtrSet<BasicBlock *, 32> Visited;
   workStack.push_back(V);
 
   do {
@@ -37,7 +37,7 @@
     InfoRec &CurVInfo = Info[currentBB];
 
     // Visit each block only once.
-    if (visited.insert(currentBB).second) {
+    if (Visited.insert(currentBB)) {
       CurVInfo.Semi = ++N;
       CurVInfo.Label = currentBB;
       
@@ -55,7 +55,7 @@
       InfoRec &SuccVInfo = Info[*PI];
       if (SuccVInfo.Semi == 0) {
         SuccVInfo.Parent = currentBB;
-        if (!visited.count(*PI)) {
+        if (!Visited.count(*PI)) {
           workStack.push_back(*PI);   
           visitChild = true;
         }

Modified: llvm/trunk/lib/VMCore/Dominators.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Dominators.cpp?rev=40829&r1=40828&r2=40829&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/Dominators.cpp (original)
+++ llvm/trunk/lib/VMCore/Dominators.cpp Sat Aug  4 19:15:57 2007
@@ -211,7 +211,7 @@
 void DominatorTree::Compress(BasicBlock *VIn) {
 
   std::vector<BasicBlock *> Work;
-  std::set<BasicBlock *> Visited;
+  SmallPtrSet<BasicBlock *, 32> Visited;
   BasicBlock *VInAncestor = Info[VIn].Ancestor;
   InfoRec &VInVAInfo = Info[VInAncestor];
 
@@ -225,9 +225,9 @@
     InfoRec &VAInfo = Info[VAncestor];
 
     // Process Ancestor first
-    if (Visited.count(VAncestor) == 0 && VAInfo.Ancestor != 0) {
+    if (Visited.insert(VAncestor) &&
+        VAInfo.Ancestor != 0) {
       Work.push_back(VAncestor);
-      Visited.insert(VAncestor);
       continue;
     } 
     Work.pop_back();