[llvm-commits] [llvm] r40823 - /llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp

Chris Lattner sabre at nondot.org
Sat Aug 4 14:06:16 PDT 2007


Author: lattner
Date: Sat Aug  4 16:06:15 2007
New Revision: 40823

URL: http://llvm.org/viewvc/llvm-project?rev=40823&view=rev
Log:
Use getNumPreds(BB) instead of computing them manually. This is a very small but
measurable speedup.

Modified:
    llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp

Modified: llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp?rev=40823&r1=40822&r2=40823&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp Sat Aug  4 16:06:15 2007
@@ -496,14 +496,14 @@
     if (&BB->front() != SomePHI)
       continue;
 
-    // Count the number of preds for BB.
-    SmallVector<BasicBlock*, 16> Preds(pred_begin(BB), pred_end(BB));
-
     // Only do work here if there the PHI nodes are missing incoming values.  We
     // know that all PHI nodes that were inserted in a block will have the same
     // number of incoming values, so we can just check any of them.
-    if (SomePHI->getNumIncomingValues() == Preds.size())
+    if (SomePHI->getNumIncomingValues() == getNumPreds(BB))
       continue;
+
+    // Get the preds for BB.
+    SmallVector<BasicBlock*, 16> Preds(pred_begin(BB), pred_end(BB));
     
     // Ok, now we know that all of the PHI nodes are missing entries for some
     // basic blocks.  Start by sorting the incoming predecessors for efficient





More information about the llvm-commits mailing list