[llvm-commits] [llvm] r40502 - /llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp

[Evan Cheng]

On Aug 1, 2007, at 3:36 PM, Chris Lattner wrote:

>
> On Aug 1, 2007, at 3:20 PM, Evan Cheng wrote:
>
>>>> I do want to support static codegen for JIT. If non-JIT mode
>>>> silently
>>>> change it to dynamic-no-pic, then we can't emulate with llc.
>>>>
>>>> An alternative is to define a code model that is somewhere between
>>>> small and medium. It's only used by Mac OS / static though. Not  
>>>> sure
>>>> if that's cleaner?
>>>
>>> Okay, instead of checking for isTargetDarwin() in this low-level
>>> place, what do you think of adding a new subtarget field, which is
>>> only set on darwin, and checking that instead?  The idea of doing
>>> this is that instead of checking isTargetDarwin(), you would check
>>> ST-
>>>> hasNoSmallModel() or something, which is more obvious to the reader
>>> what is going on.
>>
>> A subtarget field is an acceptable compromise. However, it's not
>> hasNoSmallModel(). We are still using small code model (i.e.
>> everything must fit within 4G). It's just the lower 4G is not
>> available.
>
> Ah, so everything fits in "some" 4g, but just not the "low"  4g?

Yep.

Evan

>
> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits