[llvm-commits] [llvm] r37940 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAGNodes.h include/llvm/ParameterAttributes.h lib/AsmParser/Lexer.l lib/AsmParser/llvmAsmParser.y lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp lib/Target/TargetCallingConv.td lib/Target/X86/X86CallingConv.td lib/VMCore/Function.cpp lib/VMCore/Verifier.cpp utils/TableGen/CallingConvEmitter.cpp

[Duncan Sands]

Hi Reid,

> > +    ByVal             = 1<<4,  ///< Struct passed by value
> 
> I would prefer this be named StructByVal, to be clear

this was changed because it should also be possible to pass arrays
by value, not just structs.  So it is rather the comment that should
be fixed, not the name.  That said, ByVal is a little confusing since
eg an integer is passed by value but is not marked ByVal.  Not clear
what a better name would be...

Ciao,

Duncan.