[llvm-commits] [website] r37887 - in /website/trunk: ./ docs/ docs/CVS/ docs/img/ docs/img/CVS/ img/ subproj/ subproj/llvm/ subproj/test-suite/

Reid Spencer rspencer at reidspencer.com
Thu Jul 5 00:33:12 PDT 2007


On Wed, 2007-07-04 at 23:58 -0700, Chris Lattner wrote:
> On Jul 4, 2007, at 11:04 PM, Chris Lattner wrote:
> 
> > Author: lattner
> > Date: Thu Jul  5 01:04:45 2007
> > New Revision: 37887
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=37887&view=rev
> > Log:
> > initial prototype for a new web page.
> >
> >
> >
> > [This commit notification would consist of 21 parts,
> > which exceeds the limit of 10 ones, so it was shortened to the  
> > summary.]
> 
> Wow, this sucks.  Instead of telling me everything, it told me nothing.

The defaults were set too low for both the size of the email (100K) and
the maximum number of parts (files changed = 10).  I've changed it so
that it will just print all the diffs up to 1MB. If the diff is larger
than that then it will do "showurls" which means it will print the
viewvc URL that will generate the diff for each file changed. This seems
like a reasonable compromise to me. 

> Why shorten at all? 

Because many email servers can't handle huge messages. The larges
message in my commits folder is 3.5 MB and that one takes my email
reader about 30 seconds to format. This seems "too big" to me so I set
the limit to 1.0MB.

>  If we need to shorten, we should at least list  
> the files that changed.

Yes, that's what the "showurls" option does.

> 
> Also, the URL: links are always incorrect for multi-file commits.

How so? Consider r37887. The URL specified is:

http://llvm.org/viewvc/llvm-project?view=revision&revision=37887

Which works fine for me .. gives a nice list of all the files you added
for the revision. 135 files added. While this one bumped up against the
previous limit (as discussed above), it still provided a URL that allows
you to see the changes. In the future, when you exceed the 1MB limit,
this will list a URL for each file changed. The URL takes you to a page
that shows you a side-by-side diff of the change.

FOr example, consider r37885. It provides the following URLS:
http://llvm.org/viewvc/llvm-project/llvm-top/trunk/Makefile?rev=37885&r1=37884&r2=37885&view=diff
http://llvm.org/viewvc/llvm-project/llvm-top/trunk/README.txt?rev=37885&r1=37884&r2=37885&view=diff 

Try them, its quite nice :)

Reid.

P.S. I'm also reviewing other configuration settings in svn-mailer.conf
that might need to be upgraded.




> 
> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list