[llvm-commits] [llvm] r37820 - /llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp

[Devang Patel]

Author: dpatel
Date: Fri Jun 29 18:11:49 2007
New Revision: 37820

URL: http://llvm.org/viewvc/llvm-project?rev=37820&view=rev
Log:
Preserve DominanceFrontier.

Modified:
    llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp?rev=37820&r1=37819&r2=37820&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp Fri Jun 29 18:11:49 2007
@@ -84,6 +84,7 @@
       AU.addRequiredID(LoopSimplifyID);
       AU.addPreservedID(LoopSimplifyID);
       AU.addPreserved<DominatorTree>();
+      AU.addPreserved<DominanceFrontier>();
       AU.addRequired<LoopInfo>();
       AU.addPreserved<LoopInfo>();
       AU.addRequiredID(LCSSAID);
@@ -415,6 +416,9 @@
 
   if (DominatorTree *DT = getAnalysisToUpdate<DominatorTree>())
     DT->addNewBlock(New, Old);
+
+  if (DominanceFrontier *DF = getAnalysisToUpdate<DominanceFrontier>())
+    DF->splitBlock(Old);
     
   return New;
 }
@@ -471,7 +475,7 @@
 // If Orig is in Loop then find and use Orig dominator's cloned block as NewBB 
 // dominator.
 void CloneDomInfo(BasicBlock *NewBB, BasicBlock *Orig, Loop *L, 
-                  DominatorTree *DT, 
+                  DominatorTree *DT, DominanceFrontier *DF,
                   DenseMap<const Value*, Value*> &VM) {
 
   DomTreeNode *OrigNode = DT->getNode(Orig);
@@ -481,7 +485,7 @@
   BasicBlock *NewIDom = OrigIDom;
   if (L->contains(OrigIDom)) {
     if (!DT->getNode(OrigIDom))
-      CloneDomInfo(NewIDom, OrigIDom, L, DT, VM);
+      CloneDomInfo(NewIDom, OrigIDom, L, DT, DF, VM);
     NewIDom = cast<BasicBlock>(VM[OrigIDom]);
   }
   if (NewBB == NewIDom) {
@@ -489,6 +493,23 @@
     DT->changeImmediateDominator(NewBB, NewIDom);
   } else
     DT->addNewBlock(NewBB, NewIDom);
+
+  DominanceFrontier::DomSetType NewDFSet;
+  if (DF) {
+    DominanceFrontier::iterator DFI = DF->find(Orig);
+    if ( DFI != DF->end()) {
+      DominanceFrontier::DomSetType S = DFI->second;
+      for (DominanceFrontier::DomSetType::iterator I = S.begin(), E = S.end();
+           I != E; ++I) {
+        BasicBlock *BB = *I;
+        if (L->contains(BB)) 
+          NewDFSet.insert(cast<BasicBlock>(VM[Orig]));
+        else
+          NewDFSet.insert(BB);
+      }
+    }
+    DF->addBasicBlock(NewBB, NewDFSet);
+  }
 }
 
 /// CloneLoop - Recursively clone the specified loop and all of its children,
@@ -532,12 +553,14 @@
   BranchInst *BRI = new BranchInst(TrueDest, FalseDest, BranchVal, InsertPt);
 
   // Update dominator info.
+  // BranchVal is a new preheader so it dominates true and false destination
+  // loop headers.
   if (DominatorTree *DT = getAnalysisToUpdate<DominatorTree>()) {
-    // BranchVal is a new preheader so it dominates true and false destination
-    // loop headers.
     DT->changeImmediateDominator(TrueDest, BRI->getParent());
     DT->changeImmediateDominator(FalseDest, BRI->getParent());
   }
+  // No need to update DominanceFrontier. BRI->getParent() dominated TrueDest
+  // and FalseDest anyway. Now it immediately dominates them.
 }
 
 
@@ -679,11 +702,12 @@
   }
 
   // Update dominator info
+  DominanceFrontier *DF = getAnalysisToUpdate<DominanceFrontier>();
   if (DominatorTree *DT = getAnalysisToUpdate<DominatorTree>())
     for (unsigned i = 0, e = LoopBlocks.size(); i != e; ++i) {
       BasicBlock *LBB = LoopBlocks[i];
       BasicBlock *NBB = NewBlocks[i];
-      CloneDomInfo(NBB, LBB, L, DT, ValueMap);
+      CloneDomInfo(NBB, LBB, L, DT, DF, ValueMap);
     }
   
   // Splice the newly inserted blocks into the function right before the