[llvm-commits] CVS: llvm/configure Makefile.rules Makefile.config.in

[David A. Greene]

On Thursday 28 June 2007 20:14, Reid Spencer wrote:

> > Index: llvm/configure
>
> Please don't commit generated files with non-generated files.

Oops, sorry about that.

> > +# If DISABLE_EXPENSIVE_CHECKS=1 is specified (make command line or
> > configured), +# then disable expensive checks by defining the appropriate
> > preprocessor symbols.
>
> This comment doesn't jive with the code below. The comment talks about
> DISABLE_* while the code is for ENABLE_*  .. please synchronize

I noticed that just before I had to leave for a meeting.  I'll get a fix in 
tonight.


> >  CXX.Flags     += $(CXXFLAGS) -Woverloaded-virtual
> >  C.Flags       += $(CFLAGS)
> > -CPP.BaseFlags += $(CPPFLAGS)
> > +CPP.Defines   += $(CPPFLAGS)
> > +CPP.BaseFlags += $(CPP.Defines)
>
> You're introducing CPP.Defines but I don't see it used in this file. Is
> this for future use?

Ah, I think that's an artifact of something I was going to do for llvm-config
but decided against.  I'll clean it up.

Thanks for the feedback.

                                               -Dave