[llvm-commits] CVS: llvm/lib/Analysis/ScalarEvolution.cpp

[Chris Lattner]

> In SCEVAddExpr::get, skip over any cast operands before looking for  
> nested
> add operands after constant operands. The recent change to recognize
> sign-extend expressions caused this to be exposed more often.

Ok

> +  // Now we know the first non-constant operand.  Skip past any  
> cast SCEVs.
> +  while (Idx < Ops.size() && Ops[Idx]->getSCEVType() < scAddExpr)
> +    ++Idx;

Can you please introduce a predicate for this?  Comparing against  
scAddExpr is not obvious :)

Thanks Dan,

-Chris