[llvm-commits] CVS: llvm/lib/Support/APInt.cpp

Chris Lattner clattner at apple.com
Wed May 16 13:30:34 PDT 2007


> Fix a bug in the "fromString" method where radix 2,8 and 16 values  
> were
> not being generated correctly because the shl operator does not  
> mutate its
> object but returns a new value. Also, make the distinction between  
> radix
> 16 and the others more clear.

FWIW, I find this part of the API extremely confusing.  What do you  
think about changing the "in place" operators to not return *this?

That would make it very clear which ones mutate in place and which  
ones return their result.

-Chris



More information about the llvm-commits mailing list