[llvm-commits] CVS: llvm/lib/Support/MemoryBuffer.cpp

[Reid Spencer]

On Sun, 2007-05-06 at 00:43 -0700, Chris Lattner wrote:
> >> +  MemoryBufferMMapFile() {}
> >> +
> >> +  bool open(const sys::Path &Filename);
> >
> > Shouldn't this have a parameter to receive the error message ?
> 
> No, because membuffer doesn't know why the open failed.  It would  
> always return the same thing.

It must be passed up from lib/System. I suggested this in my other
comments on these changes. 

It is not acceptable to force the application to print something like:

"file: can't open: don't know why, we just can't"

(I'm exaggerating but you get the point)

Reid.

> 
> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits