[llvm-commits] CVS: llvm/include/llvm/Pass.h

[Chris Lattner]

 From IRC:

heisenbug: /gdm/llvm/include/llvm/Pass.h: In destructor 'virtual  
llvm::Pass::~Pass()':
heisenbug: /gdm/llvm/include/llvm/Pass.h:91: warning: possible  
problem detected in invocation of delete operator:
heisenbug:
/gdm/llvm/include/llvm/Pass.h:91: warning: invalid use of undefined  
type 'struct llvm::AnalysisResolver'

Can you please move the dtor out of line?  Thanks,

-Chris

On Apr 26, 2007, at 2:07 PM, Devang Patel wrote:

>
>
> Changes in directory llvm/include/llvm:
>
> Pass.h updated: 1.84 -> 1.85
> ---
> Log message:
>
> Delete Analysis Resolver.
>
>
> ---
> Diffs of the changes:  (+1 -1)
>
>  Pass.h |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> Index: llvm/include/llvm/Pass.h
> diff -u llvm/include/llvm/Pass.h:1.84 llvm/include/llvm/Pass.h:1.85
> --- llvm/include/llvm/Pass.h:1.84	Mon Apr 16 15:56:24 2007
> +++ llvm/include/llvm/Pass.h	Thu Apr 26 16:06:41 2007
> @@ -88,7 +88,7 @@
>    Pass(const Pass &);           // DO NOT IMPLEMENT
>  public:
>    Pass() : Resolver(0), PassInfoCache(0) {}
> -  virtual ~Pass() {} // Destructor is virtual so we can be subclassed
> +  virtual ~Pass() { delete Resolver; } // Destructor is virtual so  
> we can be subclassed
>
>    /// getPassName - Return a nice clean name for a pass.  This  
> usually
>    /// implemented in terms of the name that is registered by one  
> of the
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits