[llvm-commits] [llvm] r36266 - /llvm/trunk/CREDITS.TXT
Anton Korobeynikov
asl at math.spbu.ru
Sat Apr 21 01:47:33 PDT 2007
Reid,
> I thought we were going to turn these into the actual user's name. Has
> that mapping gone away? I think the old CVS one make the reply-to field
> be the user's actual email address rather than "name at zion.cs.uiuc.edu".
> I think we need to do the same here. Otherwise the process of commit
> review gets harder.
Such mapping was done, but for all "CVS-style" accounts. David should
just add corresponding mapping username => e-mail to the special section
of the configuration file.
> Is this just failing because you were expecting "reid" instead of
> cscollab-rspencer.
Definitely. Script was pre-populated with all current CVS accounts'
> > Author: cscollab-rspencer
>
> Real name would be nice here too.
Hmm. Ok, I'll see, what can be done here.
> If its a one line log comment, can we get it on the "Log" line,
> otherwise can we indent the lines a few of spaces, as in Modified: field
> below?
I'll check this.
>
> >
> > Modified:
> > llvm/trunk/CREDITS.TXT
> >
>
> I thought we were going to run the diff output through diffstat and
> insert the histogram here like we did for CVS?
Unfortunately, No. This isn't possible here, since diffs are generated
per each files separately. Including diffstat will need to redesign
everything.
>
> > Modified: llvm/trunk/CREDITS.TXT
>
> The usual diff line here is "Index: ...". Is this the way svn diff
> generates it or can we fix it?
"Index" is just CVS'ism. In fact, patch just ignores everything below
"---" and "+++" and treat them as comment.
--
With best regards, Anton Korobeynikov.
Faculty of Mathematics & Mechanics, Saint Petersburg State University.
More information about the llvm-commits
mailing list