[llvm-commits] CVS: llvm/lib/Target/X86/X86IntelAsmPrinter.cpp

[Chris Lattner]

On Apr 20, 2007, at 3:01 PM, Jeff Cohen wrote:
> Chris Lattner wrote:
>> This isn't the right place to do this. Is LLVM synthesizing  
>> references to write? Where is the reference coming from? -Chris
>
> Analysis\IPA\Andersens.cpp line 617

This code is "research quality" anyway, I wouldn't worry about it.

> Transforms\Utils\LowerInvoke.cpp, line 152

Interesting.  I'd be fine with just removing the calls to write, this  
code is going away in the next month or two anyway.  I'd rather  
remove the "nice" message than have code in the asmprinter to munge  
the name.

> Yeah, I was afraid of that, but I'm just trying to get it to work  
> at this point (at least code that doesn't actually call write() ).   
> It's also synthesizing references to abort() as well.

Sure, but finding the right solution is still important :).  Please  
remove the asmprinter code and remove the write stuff from  
lowerinvoke, and I think we're good,

Thanks Jeff!

-Chris

>> On Apr 19, 2007, at 5:34 PM, Jeff Cohen wrote:
>>> Changes in directory llvm/lib/Target/X86: X86IntelAsmPrinter.cpp  
>>> updated: 1.70 -> 1.71 --- Log message: Make Microsoft assembler  
>>> and linker happy. --- Diffs of the changes: (+4 -0)  
>>> X86IntelAsmPrinter.cpp | 4 ++++ 1 files changed, 4 insertions(+)  
>>> Index: llvm/lib/Target/X86/X86IntelAsmPrinter.cpp diff -u llvm/ 
>>> lib/Target/X86/X86IntelAsmPrinter.cpp:1.70 llvm/lib/ Target/X86/ 
>>> X86IntelAsmPrinter.cpp:1.71 --- llvm/lib/Target/X86/ 
>>> X86IntelAsmPrinter.cpp:1.70	Tue Apr 17 12:21:52 2007 +++ llvm/lib/ 
>>> Target/X86/X86IntelAsmPrinter.cpp	Thu Apr 19 19:33:54 2007 @@  
>>> -355,6 +355,10 @@ if (I->hasDLLImportLinkage()) { O <<  
>>> "__imp_"; } + // Microsoft sticks an extra _ in front of  
>>> "_write" (whether LLVM should + // hard-code usage of a Unix API  
>>> is another question). + if (Name == "_write") + Name = "__write";  
>>> O << Name << ":near\n"; }  
>>> _______________________________________________ llvm-commits  
>>> mailing list llvm-commits at cs.uiuc.edu http://lists.cs.uiuc.edu/ 
>>> mailman/listinfo/llvm-commits
>> _______________________________________________ llvm-commits  
>> mailing list llvm-commits at cs.uiuc.edu http://lists.cs.uiuc.edu/ 
>> mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits