[llvm-commits] CVS: llvm/lib/Target/X86/X86ISelLowering.cpp X86ISelLowering.h X86InstrInfo.td X86RegisterInfo.cpp

Chris Lattner clattner at apple.com
Tue Apr 17 09:31:15 PDT 2007


>
> Implemented correct stack probing on mingw/cygwin for dynamic  
> alloca's.
> Also, fixed static case in presence of eax livin. This fixes PR331:  
> http://llvm.org/PR331

Cool :)

>
> +SDOperand X86TargetLowering::LowerDYNAMIC_STACKALLOC(SDOperand Op,
> +                                                     SelectionDAG  
> &DAG) {

Please add a comment above this that explains why this lowering is  
needed.  Also, please assert that the subtarget isCygMing() on entry,  
to make it obvious to the reader that this is cygwin-specific
lowering code.

Thanks Anton!

-Chris






More information about the llvm-commits mailing list