[llvm-commits] CVS: llvm/lib/Target/X86/X86Subtarget.cpp

[Jeff Cohen]

Yes, it worked for AMD.  I have AMD, and I wrote the code to support 
AMD.  I left the code the way it was because it was correct for AMD.  I 
actually tested it on an AMD system.

Anton Korobeynikov wrote:
> Jeff,
>
>   
>> Before assuming that the original code didn't work for Athlon64, the person who
>> replaced it with a FIXME should have determined what did work.  Then he would have
>> realized that the code was in fact correct, and would have avoided breaking it.
>>     
> The prev. code didn't know about AMD processors at all. It was one big
> "FIXME: support AMD processors". You can just look into diff for 1.53 to
> verify it. I wasn't be able to verify 64-bit stuff that's why I put
> another FIXME there. 
>
> So, I don't see any breakage here.
>
>   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20070416/1c44ea2f/attachment.html>