[llvm-commits] CVS: llvm/test/lib/llvm.exp

[Reid Spencer]

On Sun, 2007-04-15 at 11:18 -0700, Chris Lattner wrote:
> On Apr 15, 2007, at 11:13 AM, Reid Spencer wrote:
> 
> > On Sun, 2007-04-15 at 11:04 -0700, Chris Lattner wrote:
> >>> 1. Only read the first 1024 bytes of the file. The RUN: lines
> >>> should all be
> >>>    within that amount of space.  This keeps I/O costs down when
> >>> reading
> >>>    very large files.
> >>
> >> If this is such a big deal, why not run command line 'grep RUN:' over
> >> the file first, and have tcl process the output of that?
> >
> > That doesn't save you the I/O.
> 
> Have you timed how long it takes to grep through a 1M file?

I'm not claiming this is a huge performance win :)

Reid.

> 
> -Chris
> 
> >>
> >> -Chris
> >>
> >>> 2. Print PR numbers with a PR prefix so it is clear what they are.
> >>>
> >>>
> >>> ---
> >>> Diffs of the changes:  (+2 -2)
> >>>
> >>>  llvm.exp |    4 ++--
> >>>  1 files changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>>
> >>> Index: llvm/test/lib/llvm.exp
> >>> diff -u llvm/test/lib/llvm.exp:1.9 llvm/test/lib/llvm.exp:1.10
> >>> --- llvm/test/lib/llvm.exp:1.9	Sun Apr 15 02:34:58 2007
> >>> +++ llvm/test/lib/llvm.exp	Sun Apr 15 05:27:54 2007
> >>> @@ -106,7 +106,7 @@
> >>>      set testFileId [ open $test r]
> >>>      set runline ""
> >>>      set PRNUMS ""
> >>> -    foreach line [split [read $testFileId] \n] {
> >>> +    foreach line [split [read $testFileId 1024] \n] {
> >>>
> >>>        # if its the END. line then stop parsing (optimization for
> >>> big files)
> >>>        if {[regexp {END.[ *]$} $line match endofscript]} {
> >>> @@ -128,7 +128,7 @@
> >>>        # if its an PR line, save the problem report number
> >>>        } elseif {[regexp {PR([0-9]+)} $line match prnum]} {
> >>>          if {$PRNUMS == ""} {
> >>> -          set PRNUMS $prnum
> >>> +          set PRNUMS "PR$prnum"
> >>>          } else {
> >>>            set PRNUMS "$PRNUMS,$prnum"
> >>>          }
> >>>
> >>>
> >>>
> >>> _______________________________________________
> >>> llvm-commits mailing list
> >>> llvm-commits at cs.uiuc.edu
> >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >>
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits