[llvm-commits] CVS: llvm/lib/VMCore/Dominators.cpp

Owen Anderson resistor at mac.com
Sat Apr 14 16:57:21 PDT 2007



Changes in directory llvm/lib/VMCore:

Dominators.cpp updated: 1.93 -> 1.94
---
Log message:

Fix some unsafe code.  Also, tabs -> spaces.


---
Diffs of the changes:  (+6 -6)

 Dominators.cpp |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)


Index: llvm/lib/VMCore/Dominators.cpp
diff -u llvm/lib/VMCore/Dominators.cpp:1.93 llvm/lib/VMCore/Dominators.cpp:1.94
--- llvm/lib/VMCore/Dominators.cpp:1.93	Sat Apr 14 18:49:24 2007
+++ llvm/lib/VMCore/Dominators.cpp	Sat Apr 14 18:57:00 2007
@@ -929,13 +929,13 @@
 
   // Haven't calculated this node yet?  Get or calculate the node for the
   // immediate dominator.
-	BasicBlock *IDom = getAnalysis<DominatorTree>().getNode(BB)->getIDom()->getBlock();
+  DominatorTree::Node *node= getAnalysis<DominatorTree>().getNode(BB);
 
   // If we are unreachable, we may not have an immediate dominator.
-  if (!IDom)
+  if (!node || !node->getIDom())
     return BBNode = new ETNode(BB);
   else {
-    ETNode *IDomNode = getNodeForBlock(IDom);
+    ETNode *IDomNode = getNodeForBlock(node->getIDom()->getBlock());
     
     // Add a new tree node for this BasicBlock, and link it as a child of
     // IDomNode
@@ -953,9 +953,9 @@
   Function *F = Root->getParent();
   // Loop over all of the reachable blocks in the function...
   for (Function::iterator I = F->begin(), E = F->end(); I != E; ++I) {
-		DominatorTree::Node* node = DT.getNode(I);
+    DominatorTree::Node* node = DT.getNode(I);
     if (node && node->getIDom()) {  // Reachable block.
-			BasicBlock* ImmDom = node->getIDom()->getBlock();
+      BasicBlock* ImmDom = node->getIDom()->getBlock();
       ETNode *&BBNode = Nodes[I];
       if (!BBNode) {  // Haven't calculated this node yet?
         // Get or calculate the node for the immediate dominator
@@ -967,7 +967,7 @@
         BBNode->setFather(IDomNode);
       }
     }
-	}
+  }
 
   // Make sure we've got nodes around for every block
   for (Function::iterator I = F->begin(), E = F->end(); I != E; ++I) {






More information about the llvm-commits mailing list