[llvm-commits] CVS: llvm/include/llvm/Transforms/Utils/FunctionUtils.h

[Chris Lattner]

> Expunge DomSet from CodeExtractor.  This is part of the continuing  
> work
> on PR1171: http://llvm.org/PR1171 .

Cool.
>

> --- llvm/include/llvm/Transforms/Utils/FunctionUtils.h:1.9	Sun Nov   
> 5 13:31:28 2006
> +++ llvm/include/llvm/Transforms/Utils/FunctionUtils.h	Sat Apr  7  
> 00:31:27 2007
> @@ -14,6 +14,7 @@
>  #ifndef LLVM_TRANSFORMS_UTILS_FUNCTION_H
>  #define LLVM_TRANSFORMS_UTILS_FUNCTION_H
>
> +#include <llvm/Analysis/Dominators.h>

LLVM headers should be #included with "", not with <>.

Also, please remove this #include entirely, and just forward declare  
ETForest/DominatorTree.

Thanks,

-Chris

>  #include <vector>
>
>  namespace llvm {
> @@ -24,13 +25,13 @@
>
>    /// ExtractCodeRegion - rip out a sequence of basic blocks into  
> a new function
>    ///
> -  Function* ExtractCodeRegion(DominatorSet &DS,
> +  Function* ExtractCodeRegion(ETForest &DS, DominatorTree& DT,
>                                const std::vector<BasicBlock*> &code,
>                                bool AggregateArgs = false);
>
>    /// ExtractLoop - rip out a natural loop into a new function
>    ///
> -  Function* ExtractLoop(DominatorSet &DS, Loop *L,
> +  Function* ExtractLoop(ETForest &DS, DominatorTree& DT, Loop *L,
>                          bool AggregateArgs = false);
>
>    /// ExtractBasicBlock - rip out a basic block into a new function
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits