[llvm-commits] CVS: llvm/lib/VMCore/Verifier.cpp

Chris Lattner clattner at apple.com
Wed Apr 4 18:06:28 PDT 2007


On Apr 4, 2007, at 5:57 PM, Reid Spencer wrote:

> On Wed, 2007-04-04 at 17:38 -0700, Chris Lattner wrote:
>>> Implement the llvm.bit.part_select.iN.iN.iN overloaded intrinsic.
>>
>> Should this check that the third type is smaller than the other two?
>
> No, because that commit comment is in error. I was thinking of the
> prototype for part_set (which I deleted from the implementation just
> before commit). The prototype is actually like this:
>
> declare i17 @llvm.bit.part_select.i17.i17 (i17 %val, i32 %loBit, i32 %
> hiBit)
>
> which only has two variable parts: result, 1st arg. And those two must
> be the same width which is what this patch does.  The other parameters
> are i32.

Gotcha, ok.

-Chris



More information about the llvm-commits mailing list