[llvm-commits] CVS: llvm/lib/Transforms/Scalar/InstructionCombining.cpp
Chris Lattner
clattner at apple.com
Mon Mar 26 12:03:46 PDT 2007
On Mar 26, 2007, at 11:33 AM, Reid Spencer wrote:
> On Mon, 2007-03-26 at 11:29 -0700, Chris Lattner wrote:
>>> @@ -57,6 +57,9 @@
>>> #include "llvm/ADT/STLExtras.h"
>>> #include <algorithm>
>>> #include <set>
>>> +#ifndef NDEBUG
>>> +#include <sstream>
>>> +#endif
>>
>> Please don't conditionally #include files.
>
> Why? You would get sstream #included in a release build when it isn't
> used in a release build. Seems pointless to me.
Because someone will later add code to instcombine that uses sstream
that isn't itself guarded by the NDEBUG ifdef. Suddenly the release
builds start failing.
-Chris
More information about the llvm-commits
mailing list