[llvm-commits] CVS: llvm/test/Transforms/InstCombine/APInt/
Reid Spencer
rspencer at reidspencer.com
Sat Mar 24 15:27:45 PDT 2007
On Sat, 2007-03-24 at 15:26 -0700, Chris Lattner wrote:
> >> Hrm? Why a subdirectory?
> >
> > Three reasons:
> > 1. Many of the tests are similar but just modified for APInt. So
> > instead
> > of having
> > sext-apint.ll and zext-apint.ll and or-apint.ll, etc., I just
> > factored the name
> > out into a directory. Also reduces clutter in the
> > test/Transforms/InstCombine
> > directory.
>
> the is no logical difference between apint tests and non-apint tests
> for instcombine. If you want to include apint in the filename,
> that's fine, but I don't think a directory is useful.
>
> > 2. To allow "make check TESTSUITE=test/Transforms/InstCombine/
> > APInt" to
> > just check
> > the APInt versions of these tests.
>
> This is a temporary convenience while you're working on apint'ifying
> instcombine. This will not be useful once you're done.
Okay, that's fine. Could you please copy all the ,v files from the
InstCombine/APInt files up one level, being sure not to overwrite any
existing ones of the same name. If you want to rename them all with a
-apint suffix, that would be fine. I'll do the rest after the ,v files
are copied.
Thanks,
Reid.
More information about the llvm-commits
mailing list