[llvm-commits] CVS: llvm/include/llvm/CodeGen/SelectionDAGISel.h

Chris Lattner clattner at apple.com
Tue Mar 6 10:34:15 PST 2007


> Enumerate SDISel formal parameter attributes. Make use of new
> enumeration.

Cool.

> +  namespace SDISelParamFlags {
> +    enum Flags {
> +      NoFlagSet         = 0,
> +      Signed            = 1<<0,
> +      SignedOffs        = 0,

Can you please rename 'Signed' to 'SExt' for consistency?  Can you  
please also add "ZExt" as well?

-Chris

> +      InReg             = 1<<1,
> +      InRegOffs         = 1,
> +      StructReturn      = 1<<2,
> +      StructReturnOffs  = 2,
> +      OrigAlignment     = 0x1F<<27,
> +      OrigAlignmentOffs = 27
> +    };
> +  }
> +
>  /// SelectionDAGISel - This is the common base class used for  
> SelectionDAG-based
>  /// pattern-matching instruction selectors.
>  class SelectionDAGISel : public FunctionPass {
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list