[llvm-commits] CVS: llvm/include/llvm/DerivedTypes.h

[Reid Spencer]

On Sun, 2007-03-04 at 16:05 -0800, Chris Lattner wrote:
> >
> The thought occurred to me :).  However, this is used in  
> InstCombiner::SimplifyDemandedBits, which will require significant  
> work to APInt'ify.  Using a function like this (instead of localized  
> bit-twiddling) will at least help distill the intention out of the code.

Okay :)

> I strongly encourage Sheng to do instcombine one piece at a time: say  
> visitAND, then visitOR (etc) and submit them as separate patches.

I have requested that he submit daily (if not more frequent) patches.

> Blasting me with one huge patch is not going to earn brownie points,  
> and if/when it breaks something, it won't be easy to track down what  
> part of the huge change did it.

Yes, I'm well aware of that. And its not just you. I will review each of
these patches before you ever see it.

> 
> -Chris