[llvm-commits] CVS: llvm/include/llvm/ExecutionEngine/GenericValue.h

[Chris Lattner]

>>>> It would increase the memory use of the *interpreter*, but nothing
>>>> else.  The interpreter is already slow.
>>>
>>> The JIT makes use of the fields you're intending to delete as  
>>> well. SO
>>> does ExecutionEngine (on each load and store).  Sure you want to
>>> sacrifice JIT speed too?
>>
>> Yes.  The JIT does not use them for anything performance sensitive.
>
> Well, if there's a lot of global variables, it could delay start up
> time.

The change would increase memory use, but not signicantly slow down  
GenericValue.  The code paths you are talking about don't create many  
GV's at one time so the mem increase wouldn't matter.

>> Note that the interpreter is currently broken for sizes like int33.
>
> Oh? I committed patches a few days ago to fix any problems with that.
> These are patches that I've had in my tree for over a month while I  
> was
> testing the llvm-gcc patch for bitwidth. What did you find?

I may be confused, but it doesn't look like sdiv int33 does the right  
things for example.

> Actually, it doesn't matter. I'm going to make this change .. have
> already started. So far its shrunk Execution.cpp by 500 loc :)

Very nice,

-Chris