[llvm-commits] CVS: llvm/lib/VMCore/AsmWriter.cpp

[Chris Lattner]

>
> Index: llvm/lib/VMCore/AsmWriter.cpp
> diff -u llvm/lib/VMCore/AsmWriter.cpp:1.261 llvm/lib/VMCore/ 
> AsmWriter.cpp:1.262
> --- llvm/lib/VMCore/AsmWriter.cpp:1.261	Wed Feb 14 20:26:10 2007
> +++ llvm/lib/VMCore/AsmWriter.cpp	Tue Feb 27 02:34:09 2007
> @@ -464,7 +464,7 @@
>      if (CI->getType() == Type::Int1Ty)
>        Out << (CI->getZExtValue() ? "true" : "false");
>      else
> -      Out << CI->getSExtValue();
> +      Out << CI->getValue().toString(10,/*wantSigned=*/true);

Please change the method to something like "toStringSigned(10)",  
which will allow
the comment to be dropped.  Obviously if it's convenient internally,  
you can make the
two "toString*" methods call the same helper.  If there are other  
API's like this that
take a bool, please change them as well.

Does the .ll files parser support apint's yet?

-Chris