[llvm-commits] CVS: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp README.txt

Dale Johannesen dalej at apple.com
Sun Feb 25 10:31:50 PST 2007



Changes in directory llvm/lib/Target/ARM:

ARMConstantIslandPass.cpp updated: 1.29 -> 1.30
README.txt updated: 1.13 -> 1.14
---
Log message:

cosmetic changes from review of last patch.  obvious



---
Diffs of the changes:  (+5 -4)

 ARMConstantIslandPass.cpp |    4 ++--
 README.txt                |    5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)


Index: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
diff -u llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1.29 llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1.30
--- llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1.29	Sat Feb 24 19:42:36 2007
+++ llvm/lib/Target/ARM/ARMConstantIslandPass.cpp	Sun Feb 25 12:31:31 2007
@@ -558,7 +558,7 @@
   return NewBB;
 }
 
-//// OffsetIsInRange - Checks whether UserOffset is within MaxDisp of
+/// OffsetIsInRange - Checks whether UserOffset is within MaxDisp of
 /// TrialOffset.
 bool ARMConstantIslands::OffsetIsInRange(unsigned UserOffset, 
                       unsigned TrialOffset, unsigned MaxDisp, bool NegativeOK) {
@@ -631,7 +631,7 @@
 void ARMConstantIslands::AdjustBBOffsetsAfter(MachineBasicBlock *BB, int delta)
 {
   MachineFunction::iterator MBBI = BB->getParent()->end();
-  for(int i=BB->getNumber()+1; i<=prior(MBBI)->getNumber(); i++)
+  for(unsigned i=BB->getNumber()+1; i<BB->getParent()->getNumBlockIDs(); i++)
     BBOffsets[i] += delta;
 }
 


Index: llvm/lib/Target/ARM/README.txt
diff -u llvm/lib/Target/ARM/README.txt:1.13 llvm/lib/Target/ARM/README.txt:1.14
--- llvm/lib/Target/ARM/README.txt:1.13	Sat Feb 24 18:47:03 2007
+++ llvm/lib/Target/ARM/README.txt	Sun Feb 25 12:31:31 2007
@@ -24,8 +24,9 @@
 1.  When there isn't an existing water, the current MBB is split right after 
 the use.  It would be profitable to look farther forward, especially on Thumb,
 where negative offsets won't work.
-Now it will put the island at the end of the block if that is in range.  If it
-is not in range things still work as above, which is poor on Thumb.
+(Partially fixed:  it will put the island at the end of the block if that is 
+in range.  If it is not in range things still work as above, which is poor on 
+Thumb.)
 
 2.  There may be some advantage to trying to be smarter about the initial
 placement, rather than putting everything at the end.






More information about the llvm-commits mailing list