[llvm-commits] CVS: llvm/lib/Bytecode/Writer/Writer.cpp

Chris Lattner sabre at nondot.org
Fri Feb 9 23:12:07 PST 2007



Changes in directory llvm/lib/Bytecode/Writer:

Writer.cpp updated: 1.162 -> 1.163
---
Log message:

make the datastructure used in BytecodeWriter::outputValueSymbolTable
*slightly* less abusive of memory.  This speeds up the bcwriter from
1.83s to 1.32s (39% faster) on 447.dealII.


---
Diffs of the changes:  (+4 -4)

 Writer.cpp |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)


Index: llvm/lib/Bytecode/Writer/Writer.cpp
diff -u llvm/lib/Bytecode/Writer/Writer.cpp:1.162 llvm/lib/Bytecode/Writer/Writer.cpp:1.163
--- llvm/lib/Bytecode/Writer/Writer.cpp:1.162	Fri Feb  9 23:17:48 2007
+++ llvm/lib/Bytecode/Writer/Writer.cpp	Sat Feb 10 01:11:51 2007
@@ -1086,14 +1086,14 @@
                             true/*ElideIfEmpty*/);
 
   // Organize the symbol table by type
-  typedef std::pair<std::string, const Value*> PlaneMapEntry;
+  typedef std::pair<const std::string*, const Value*> PlaneMapEntry;
   typedef std::vector<PlaneMapEntry> PlaneMapVector;
   typedef std::map<const Type*, PlaneMapVector > PlaneMap;
   PlaneMap Planes;
   for (ValueSymbolTable::const_iterator SI = VST.begin(), SE = VST.end();
        SI != SE; ++SI) 
-    Planes[SI->second->getType()].push_back(
-        std::make_pair(SI->first,SI->second));
+    Planes[SI->second->getType()]
+      .push_back(std::make_pair(&SI->first, SI->second));
 
   for (PlaneMap::const_iterator PI = Planes.begin(), PE = Planes.end();
        PI != PE; ++PI) {
@@ -1112,7 +1112,7 @@
     for (; I != End; ++I) {
       // Symtab entry: [def slot #][name]
       output_vbr(Table.getSlot(I->second));
-      output(I->first);
+      output(*I->first);
     }
   }
 }






More information about the llvm-commits mailing list