[llvm-commits] CVS: llvm/lib/Target/X86/X86ATTAsmPrinter.cpp X86AsmPrinter.cpp X86TargetAsmInfo.cpp

[Chris Lattner]

Changes in directory llvm/lib/Target/X86:

X86ATTAsmPrinter.cpp updated: 1.88 -> 1.89
X86AsmPrinter.cpp updated: 1.226 -> 1.227
X86TargetAsmInfo.cpp updated: 1.21 -> 1.22
---
Log message:

add support for hidden visibility to darwin/x86


---
Diffs of the changes:  (+7 -4)

 X86ATTAsmPrinter.cpp |    5 +++--
 X86AsmPrinter.cpp    |    5 +++--
 X86TargetAsmInfo.cpp |    1 +
 3 files changed, 7 insertions(+), 4 deletions(-)


Index: llvm/lib/Target/X86/X86ATTAsmPrinter.cpp
diff -u llvm/lib/Target/X86/X86ATTAsmPrinter.cpp:1.88 llvm/lib/Target/X86/X86ATTAsmPrinter.cpp:1.89
--- llvm/lib/Target/X86/X86ATTAsmPrinter.cpp:1.88	Sun Jan 14 00:08:14 2007
+++ llvm/lib/Target/X86/X86ATTAsmPrinter.cpp	Sun Jan 14 00:29:53 2007
@@ -125,8 +125,9 @@
     }
     break;
   }
-  if (F->hasHiddenVisibility() && !Subtarget->isTargetDarwin())
-    O << "\t.hidden " << CurrentFnName << "\n";
+  if (F->hasHiddenVisibility())
+    if (const char *Directive = TAI->getHiddenDirective())
+      O << Directive << CurrentFnName << "\n";
   
   O << CurrentFnName << ":\n";
   // Add some workaround for linkonce linkage on Cygwin\MinGW


Index: llvm/lib/Target/X86/X86AsmPrinter.cpp
diff -u llvm/lib/Target/X86/X86AsmPrinter.cpp:1.226 llvm/lib/Target/X86/X86AsmPrinter.cpp:1.227
--- llvm/lib/Target/X86/X86AsmPrinter.cpp:1.226	Sat Jan 13 18:50:56 2007
+++ llvm/lib/Target/X86/X86AsmPrinter.cpp	Sun Jan 14 00:29:53 2007
@@ -246,8 +246,9 @@
       EmitGlobalConstant(C);
       O << '\n';
     }
-    if (I->hasHiddenVisibility() && !Subtarget->isTargetDarwin())
-      O << "\t.hidden " << name << "\n";
+    if (I->hasHiddenVisibility())
+      if (const char *Directive = TAI->getHiddenDirective())
+        O << Directive << name << "\n";
   }
   
   // Output linker support code for dllexported globals


Index: llvm/lib/Target/X86/X86TargetAsmInfo.cpp
diff -u llvm/lib/Target/X86/X86TargetAsmInfo.cpp:1.21 llvm/lib/Target/X86/X86TargetAsmInfo.cpp:1.22
--- llvm/lib/Target/X86/X86TargetAsmInfo.cpp:1.21	Fri Jan 12 17:28:32 2007
+++ llvm/lib/Target/X86/X86TargetAsmInfo.cpp	Sun Jan 14 00:29:53 2007
@@ -64,6 +64,7 @@
     SetDirective = "\t.set";
     UsedDirective = "\t.no_dead_strip\t";
     WeakRefDirective = "\t.weak_reference\t";
+    HiddenDirective = "\t.private_extern\t";
     
     NeedsSet = true;
     DwarfAbbrevSection = ".section __DWARF,__debug_abbrev,regular,debug";