[llvm-commits] CVS: llvm/lib/AsmParser/llvmAsmParser.y

[Chris Lattner]

On Fri, 12 Jan 2007, Reid Spencer wrote:
>> This didn't use to be dead and you've just broken llvm-upgrade which
>> will pass "NOT" through.  If the intention is not to support "NOT" any
>> more than I will add the necessary transform in llvm-upgrade.
>
> Okay, I'm wrong. The llvm-upgrade lexer wasn't recognizing it either.
> NOT is just plain dead now :)

Even if it did pass it in, the lexer would not have lexed it.  The Lexer 
never make the token, so the code in the parser is certainly dead.

-Chris

>>> ---
>>> Diffs of the changes:  (+1 -14)
>>>
>>>  llvmAsmParser.y |   15 +--------------
>>>  1 files changed, 1 insertion(+), 14 deletions(-)
>>>
>>>
>>> Index: llvm/lib/AsmParser/llvmAsmParser.y
>>> diff -u llvm/lib/AsmParser/llvmAsmParser.y:1.305 llvm/lib/AsmParser/llvmAsmParser.y:1.306
>>> --- llvm/lib/AsmParser/llvmAsmParser.y:1.305	Fri Jan 12 01:05:13 2007
>>> +++ llvm/lib/AsmParser/llvmAsmParser.y	Fri Jan 12 12:32:39 2007
>>> @@ -974,7 +974,7 @@
>>>  %token DECLARE DEFINE GLOBAL CONSTANT SECTION VOLATILE
>>>  %token TO DOTDOTDOT NULL_TOK UNDEF INTERNAL LINKONCE WEAK APPENDING
>>>  %token DLLIMPORT DLLEXPORT EXTERN_WEAK
>>> -%token OPAQUE NOT EXTERNAL TARGET TRIPLE ENDIAN POINTERSIZE LITTLE BIG ALIGN
>>> +%token OPAQUE EXTERNAL TARGET TRIPLE ENDIAN POINTERSIZE LITTLE BIG ALIGN
>>>  %token DEPLIBS CALL TAIL ASM_TOK MODULE SIDEEFFECT
>>>  %token CC_TOK CCC_TOK CSRETCC_TOK FASTCC_TOK COLDCC_TOK
>>>  %token X86_STDCALLCC_TOK X86_FASTCALLCC_TOK
>>> @@ -2611,19 +2611,6 @@
>>>      if ($$ == 0)
>>>        GEN_ERROR("fcmp operator returned null!");
>>>    }
>>> -  | NOT ResolvedVal {
>>> -    cerr << "WARNING: Use of eliminated 'not' instruction:"
>>> -         << " Replacing with 'xor'.\n";
>>> -
>>> -    Value *Ones = ConstantInt::getAllOnesValue($2->getType());
>>> -    if (Ones == 0)
>>> -      GEN_ERROR("Expected integral type for not instruction!");
>>> -
>>> -    $$ = BinaryOperator::create(Instruction::Xor, $2, Ones);
>>> -    if ($$ == 0)
>>> -      GEN_ERROR("Could not create a xor instruction!");
>>> -    CHECK_FOR_ERROR
>>> -  }
>>>    | ShiftOps ResolvedVal ',' ResolvedVal {
>>>      if ($4->getType() != Type::Int8Ty)
>>>        GEN_ERROR("Shift amount must be i8 type!");
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>

-Chris

-- 
http://nondot.org/sabre/
http://llvm.org/