[llvm-commits] CVS: llvm/test/Regression/Transforms/LevelRaise/2002-03-21-MissedRaise.ll

[Chris Lattner]

On Jan 4, 2007, at 9:49 AM, Chris Lattner wrote:

>
> llvm-upgrade gets a parse error on this testcase, so it's not being
> tested at all.  This appears to be an llvm-upgrade bug:
>
>   $ llvm-upgrade 2002-03-21-MissedRaise.ll
> llvm-upgrade: parse error
> 2002-03-21-MissedRaise.ll:7:  while reading token: '%Hash'

This actually affects a lot of testcases in the suite, leading me to  
believe that the testsuite isn't actually testing many programs.   
Reid, can you run llvm-upgrade on all the .ll files in llvm/test and  
figure out which ones it barfs on?

This is a serious problem.  For example Regression/Transforms/ 
LevelRaise/2003-05-01-CallCast.ll is reported as succeeding because  
llvm-upgrade fails to parse the input.  This means that there may be  
many tests failing and we don't know it because the failures are masked.

Perhaps in addition to returning an error code, llvm-upgrade should  
emit something like "parse failed" to the output stream, so that  
later llvm-as's will die.

-Chris