[llvm-commits] CVS: llvm/lib/Target/X86/X86ATTAsmPrinter.cpp X86AsmPrinter.cpp X86AsmPrinter.h

[Rafael Espindola]

Changes in directory llvm/lib/Target/X86:

X86ATTAsmPrinter.cpp updated: 1.78 -> 1.79
X86AsmPrinter.cpp updated: 1.221 -> 1.222
X86AsmPrinter.h updated: 1.38 -> 1.39
---
Log message:

move ExtWeakSymbols to AsmPrinter


---
Diffs of the changes:  (+2 -14)

 X86ATTAsmPrinter.cpp |    2 +-
 X86AsmPrinter.cpp    |   11 +----------
 X86AsmPrinter.h      |    3 ---
 3 files changed, 2 insertions(+), 14 deletions(-)


Index: llvm/lib/Target/X86/X86ATTAsmPrinter.cpp
diff -u llvm/lib/Target/X86/X86ATTAsmPrinter.cpp:1.78 llvm/lib/Target/X86/X86ATTAsmPrinter.cpp:1.79
--- llvm/lib/Target/X86/X86ATTAsmPrinter.cpp:1.78	Tue Dec  5 13:50:18 2006
+++ llvm/lib/Target/X86/X86ATTAsmPrinter.cpp	Sun Dec 17 21:37:18 2006
@@ -257,7 +257,7 @@
     }
 
     if (GV->hasExternalWeakLinkage())
-      ExtWeakSymbols.insert(Name);
+      ExtWeakSymbols.insert(GV);
     
     int Offset = MO.getOffset();
     if (Offset > 0)


Index: llvm/lib/Target/X86/X86AsmPrinter.cpp
diff -u llvm/lib/Target/X86/X86AsmPrinter.cpp:1.221 llvm/lib/Target/X86/X86AsmPrinter.cpp:1.222
--- llvm/lib/Target/X86/X86AsmPrinter.cpp:1.221	Sat Dec  9 17:14:08 2006
+++ llvm/lib/Target/X86/X86AsmPrinter.cpp	Sun Dec 17 21:37:18 2006
@@ -250,7 +250,7 @@
       // reference!
       if (const GlobalValue *GV = dyn_cast<GlobalValue>(C))
         if (GV->hasExternalWeakLinkage())
-          ExtWeakSymbols.insert(Mang->getValueName(GV));
+          ExtWeakSymbols.insert(GV);
 
       EmitGlobalConstant(C);
       O << '\n';
@@ -278,15 +278,6 @@
     O << "\t.ascii \" -export:" << *i << "\"\n";
   }    
 
-  if (TAI->getWeakRefDirective()) {
-    if (ExtWeakSymbols.begin() != ExtWeakSymbols.end())
-      SwitchToDataSection("");
-    for (std::set<std::string>::iterator i = ExtWeakSymbols.begin(),
-         e = ExtWeakSymbols.end(); i != e; ++i) {
-      O << TAI->getWeakRefDirective() << *i << "\n";
-    }
-  }
-  
   if (Subtarget->isTargetDarwin()) {
     SwitchToDataSection("");
 


Index: llvm/lib/Target/X86/X86AsmPrinter.h
diff -u llvm/lib/Target/X86/X86AsmPrinter.h:1.38 llvm/lib/Target/X86/X86AsmPrinter.h:1.39
--- llvm/lib/Target/X86/X86AsmPrinter.h:1.38	Wed Dec  6 12:14:47 2006
+++ llvm/lib/Target/X86/X86AsmPrinter.h	Sun Dec 17 21:37:18 2006
@@ -86,9 +86,6 @@
   // Necessary for dllexport support
   std::set<std::string> DLLExportedFns, DLLExportedGVs;
 
-  // Necessary for external weak linkage support
-  std::set<std::string> ExtWeakSymbols;
-  
   inline static bool isScale(const MachineOperand &MO) {
     return MO.isImmediate() &&
           (MO.getImmedValue() == 1 || MO.getImmedValue() == 2 ||