[llvm-commits] CVS: llvm/lib/Bytecode/Writer/Writer.cpp

[Bill Wendling]

Again, I'm really sorry that this cruft got in there...The patch I  
did was rather big and a few things escaped my attention.

-bw

On Dec 16, 2006, at 9:55 PM, Jeff Cohen wrote:

> This breaks the VC++ build with a "binary '<<' : no operator found  
> which takes a left-hand operand of type 'llvm::OStream' (or there  
> is no acceptable conversion)" error.  I would try to fix it, but  
> what is the purpose of this code other than to print some random  
> hex digits?
>
> Bill Wendling wrote:
>> Changes in directory llvm/lib/Bytecode/Writer:
>>
>> Writer.cpp updated: 1.137 -> 1.138
>> ---
>> Log message:
>>
>> Added an automatic cast to "std::ostream*" etc. from OStream. We  
>> then can
>> rework the hacks that had us passing OStream in. We pass in  
>> std::ostream*
>> instead, check for null, and then dispatch to the correct print()  
>> method.
>>
>>
>> ---
>> Diffs of the changes:  (+2 -0)
>>
>>  Writer.cpp |    2 ++
>>  1 files changed, 2 insertions(+)
>>
>>
>> Index: llvm/lib/Bytecode/Writer/Writer.cpp
>> diff -u llvm/lib/Bytecode/Writer/Writer.cpp:1.137 llvm/lib/ 
>> Bytecode/Writer/Writer.cpp:1.138
>> --- llvm/lib/Bytecode/Writer/Writer.cpp:1.137	Fri Dec  8 12:06:15  
>> 2006
>> +++ llvm/lib/Bytecode/Writer/Writer.cpp	Sat Dec 16 23:15:12 2006
>> @@ -1297,4 +1297,6 @@
>>     // make sure it hits disk now
>>    Out.stream()->flush();
>> +  void * p;
>> +  Out << std::hex << p << "\n";
>>  }
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>>
>>
>