[llvm-commits] llvm-test patch for review

[Chris Lattner]

On Dec 10, 2006, at 2:26 PM, Reid Spencer wrote:

> Hi Anton,
>
> On Sat, 2006-12-09 at 14:35 +0300, Anton Korobeynikov wrote:
>> Hello, Everyone.
>>
>> Please find patch for llvm-test for review.
>>
>> Features:
>>
>> 1. Much more mingw32-friendly. Almost all tests were fixed.
>> 2. Added features for cross-platform tests
>>
> Also,
> I would prefer better implementations of the "millisec" functions you
> added in some tests. Counting the number of calls isn't accurate given
> that you could at least call time(0) and multiply by 1000 (after
> subtracting
> the baseline value).

I don't think that we need a precise version of millisec in the  
benchmarks, we use external timing instead of internal timing, so the  
timer functions in these programs are dynamically dead or their  
output is ignored.

-Chris