[llvm-commits] CVS: llvm/test/Regression/CFrontend/extern-weak.c
Chris Lattner
clattner at apple.com
Sun Dec 3 12:52:45 PST 2006
>
> Use weak_import on linux, weak everywhere else. Makes test pass on
> Linux.
> Checking for __APPLE_CC__ is useless as this just checks to see if the
> compiler is llvm-gcc, which we know it is.
This description is wrong, and doesn't match the change you made to
the testcase. I believe we want to use weak_import only on
__APPLE_CC__ targets, as the test case originally did.
-Chris
> ---
> Diffs of the changes: (+1 -1)
>
> extern-weak.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> Index: llvm/test/Regression/CFrontend/extern-weak.c
> diff -u llvm/test/Regression/CFrontend/extern-weak.c:1.2 llvm/test/
> Regression/CFrontend/extern-weak.c:1.3
> --- llvm/test/Regression/CFrontend/extern-weak.c:1.2 Fri Dec 1
> 12:04:08 2006
> +++ llvm/test/Regression/CFrontend/extern-weak.c Sun Dec 3
> 10:40:08 2006
> @@ -1,7 +1,7 @@
> // RUN: %llvmgcc -O3 -S -o - -emit-llvm %s | grep extern_weak &&
> // RUN: %llvmgcc -O3 -S -o - -emit-llvm | llvm-as | llc
>
> -#ifdef __APPLE_CC__
> +#ifndef __linux__
> void foo() __attribute__((weak_import));
> #else
> void foo() __attribute__((weak));
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list