[llvm-commits] CVS: llvm/lib/Target/X86/X86TargetAsmInfo.cpp

[Chris Lattner]

On Nov 28, 2006, at 11:53 AM, Andrew Lenharth wrote:


> diff -u llvm/lib/Target/X86/X86TargetAsmInfo.cpp:1.7 llvm/lib/ 
> Target/X86/X86TargetAsmInfo.cpp:1.8
> --- llvm/lib/Target/X86/X86TargetAsmInfo.cpp:1.7	Tue Oct 31  
> 02:31:24 2006
> +++ llvm/lib/Target/X86/X86TargetAsmInfo.cpp	Tue Nov 28 13:52:49 2006
> @@ -14,14 +14,31 @@
>  #include "X86TargetAsmInfo.h"
>  #include "X86TargetMachine.h"
>  #include "X86Subtarget.h"
> +#include <iostream>

Please remove this #include.

>  using namespace llvm;
>
> +static const char* x86_asm_table[] = {"{si}", "S",
> +                                      "{di}", "D",
> +                                      "{ax}", "a",
> +                                      "{cx}", "c",
> +                                      "q",    "q",
> +                                      "r",    "r",
> +                                      "m",    "m",

Why not have identity translations (r -> r) be implicit?

-Chris

> +                                      "{memory}", "memory",
> +                                      "{flags}", "",
> +                                      "{dirflag}", "",
> +                                      "{fpsr}", "",
> +                                      "{cc}", "cc",
> +                                      0,0};
> +
>  X86TargetAsmInfo::X86TargetAsmInfo(const X86TargetMachine &TM) {
>    const X86Subtarget *Subtarget = &TM.getSubtarget<X86Subtarget>();
>
>    // FIXME - Should be simplified.
> -
> +
> +  AsmTransCBE = x86_asm_table;
> +
>    switch (Subtarget->TargetType) {
>    case X86Subtarget::isDarwin:
>      AlignmentIsInBytes = false;
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits