[llvm-commits] CVS: llvm/lib/Target/CBackend/Writer.cpp

[Andrew Lenharth]

Changes in directory llvm/lib/Target/CBackend:

Writer.cpp updated: 1.286 -> 1.287
---
Log message:

update comments

---
Diffs of the changes:  (+4 -2)

 Writer.cpp |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)


Index: llvm/lib/Target/CBackend/Writer.cpp
diff -u llvm/lib/Target/CBackend/Writer.cpp:1.286 llvm/lib/Target/CBackend/Writer.cpp:1.287
--- llvm/lib/Target/CBackend/Writer.cpp:1.286	Tue Nov 28 13:53:36 2006
+++ llvm/lib/Target/CBackend/Writer.cpp	Tue Nov 28 13:56:02 2006
@@ -2258,9 +2258,9 @@
 
 
 //This converts the llvm constraint string to something gcc is expecting.
-//This could be broken into a bunch of peices and spread accross the 
-//targets, but this information is only useful here.
 //TODO: work out platform independent constraints and factor those out
+//      of the per target tables
+//      handle multiple constraint codes
 std::string CWriter::InterpretASMConstraint(InlineAsm::ConstraintInfo& c) {
 
   assert(c.Codes.size() == 1 && "Too many asm constraint codes to handle");
@@ -2320,6 +2320,8 @@
   return asmstr;
 }
 
+//TODO: assumptions about what consume arguments from the call are likely wrong
+//      handle communitivity
 void CWriter::visitInlineAsm(CallInst &CI) {
   InlineAsm* as = cast<InlineAsm>(CI.getOperand(0));
   std::vector<InlineAsm::ConstraintInfo> Constraints = as->ParseConstraints();