[llvm-commits] CAST patch: #3: lib/Transforms (except instcombine)

Reid Spencer rspencer at reidspencer.com
Tue Nov 21 08:50:30 PST 2006

On Tue, 2006-11-21 at 08:32 -0800, Chris Lattner wrote:
> > I'm not sure what was going on there. I checked the size with
> > getPrimitiveSizeInBits to ensure that SV->getType() was smaller than
> > Old->getType() before making the zext. Perhaps a bool or pointer or
> > packed crept in there? I dunnot, but it didn't work.
> I realize it is not a priority for you, but after the patch goes in,  
> please try to figure out what is happening.

It is a priority for me!  But, only after this initial CAST patch goes
in. When we start removing signedness I will have to revisit every
single createInferredCast to make sure signedness can't affect it. I
will also revisit the various ConstantExpr::getCast calls that don't
pass an opcode, for the same issue. Unfortunately everyone of these is
somewhat involved and depends on having a very clear understanding of
the code that uses them. The "easy" ones have already been converted to
create the correct cast. 

> -Chris

More information about the llvm-commits mailing list