[llvm-commits] CVS: llvm/include/llvm/CodeGen/IntrinsicLowering.h

[Chris Lattner]

Changes in directory llvm/include/llvm/CodeGen:

IntrinsicLowering.h updated: 1.10 -> 1.11
---
Log message:

Simplify IntrinsicLowering and clarify that it is only for use by the
CBE and interpreter.


---
Diffs of the changes:  (+3 -30)

 IntrinsicLowering.h |   33 +++------------------------------
 1 files changed, 3 insertions(+), 30 deletions(-)


Index: llvm/include/llvm/CodeGen/IntrinsicLowering.h
diff -u llvm/include/llvm/CodeGen/IntrinsicLowering.h:1.10 llvm/include/llvm/CodeGen/IntrinsicLowering.h:1.11
--- llvm/include/llvm/CodeGen/IntrinsicLowering.h:1.10	Fri Mar 10 16:49:05 2006
+++ llvm/include/llvm/CodeGen/IntrinsicLowering.h	Wed Nov 15 12:00:10 2006
@@ -9,24 +9,7 @@
 //
 // This file defines the IntrinsicLowering interface.  This interface allows
 // addition of domain-specific or front-end specific intrinsics to LLVM without
-// having to modify all of the code generators to support the new intrinsic.
-// Later, as desired, targets can incrementally add support for particular
-// intrinsic functions, as desired, to generate better code.
-//
-// If a code generator cannot handle or does not know about an intrinsic
-// function, it will use the intrinsic lowering interface to change an intrinsic
-// function name into a concrete function name which can be used to implement
-// the functionality of the intrinsic.  For example, llvm.memcpy can be
-// implemented as a call to the math library 'memcpy' function if the target
-// doesn't have hardware support for the intrinsic, or if it has not yet been
-// implemented yet.
-//
-// Another use for this interface is the addition of domain-specific intrinsics.
-// The default implementation of this interface would then lower the intrinsics
-// to noop calls, allowing the direct execution of programs with instrumentation
-// or other hooks placed in them.  When a specific tool or flag is used, a
-// different implementation of these interfaces may be used, which activates the
-// intrinsics in some way.
+// having to modify all of the C backend or interpreter.
 //
 //===----------------------------------------------------------------------===//
 
@@ -42,12 +25,11 @@
   class IntrinsicLowering {
   public:
     IntrinsicLowering() {}
-    virtual ~IntrinsicLowering() {}
 
     /// AddPrototypes - This method, if called, causes all of the prototypes
     /// that might be needed by an intrinsic lowering implementation to be
     /// inserted into the module specified.
-    virtual void AddPrototypes(Module &M) = 0;
+    void AddPrototypes(Module &M);
 
     /// LowerIntrinsicCall - This method returns the LLVM function which should
     /// be used to implement the specified intrinsic function call.  If an
@@ -59,16 +41,7 @@
     /// _after_ the call instruction and the call is deleted.  The caller must
     /// be capable of handling this kind of change.
     ///
-    virtual void LowerIntrinsicCall(CallInst *CI) = 0;
-  };
-
-  /// DefaultIntrinsicLower - This is the default intrinsic lowering pass which
-  /// is used if no other one is specified.  Custom intrinsic lowering
-  /// implementations should pass any unhandled intrinsics to this
-  /// implementation to allow for future extensibility.
-  struct DefaultIntrinsicLowering : public IntrinsicLowering {
-    virtual void AddPrototypes(Module &M);
-    virtual void LowerIntrinsicCall(CallInst *CI);
+    void LowerIntrinsicCall(CallInst *CI);
   };
 }