[llvm-commits] [llvmgcc] CAST Patch [2/4] llvm-gcc part

Chris Lattner clattner at apple.com
Sun Nov 12 21:24:53 PST 2006


On Nov 12, 2006, at 6:48 PM, Reid Spencer wrote:

> Attached is the llvm-gcc4 patch to correspond with the new CAST
> instructions in LLVM.
>
> For Review Only.  PLEASE DO NOT COMMIT THIS!

This patch looks fine: the uses of getCast are safe, because the CFE  
never has types that disagree with what the FE thinks they are.  I  
don't think that this is used though:

@@ -147,6 +147,11 @@
  }

  namespace {
+  /// GetCast - This helper function is used to get the correct kind  
of a
+  /// cast given a tree expression
+  ConvertInst* GetCast(Value* V, const Type* Ty, tree expr) {
+  }
+
    /// FunctionPrologArgumentConversion - This helper class is  
driven by the ABI
    /// definition for this target to figure out how to retrieve  
arguments from
    /// the stack/regs coming into a function and store them into an  
appropriate

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20061112/928a53e8/attachment.html>


More information about the llvm-commits mailing list