[llvm-commits] CVS: llvm/lib/Target/X86/X86Subtarget.cpp X86Subtarget.h

[Evan Cheng]

Changes in directory llvm/lib/Target/X86:

X86Subtarget.cpp updated: 1.36 -> 1.37
X86Subtarget.h updated: 1.19 -> 1.20
---
Log message:

Proper fix for rdar://problem/4770604   Thanks to Stuart Hastings!



---
Diffs of the changes:  (+21 -12)

 X86Subtarget.cpp |   25 +++++++++++++------------
 X86Subtarget.h   |    8 ++++++++
 2 files changed, 21 insertions(+), 12 deletions(-)


Index: llvm/lib/Target/X86/X86Subtarget.cpp
diff -u llvm/lib/Target/X86/X86Subtarget.cpp:1.36 llvm/lib/Target/X86/X86Subtarget.cpp:1.37
--- llvm/lib/Target/X86/X86Subtarget.cpp:1.36	Fri Oct  6 13:57:51 2006
+++ llvm/lib/Target/X86/X86Subtarget.cpp	Mon Oct 16 16:00:37 2006
@@ -26,21 +26,22 @@
     clEnumValN(X86Subtarget::intel, "intel", "  Emit Intel-style assembly"),
     clEnumValEnd));
 
+
 /// GetCpuIDAndInfo - Execute the specified cpuid and return the 4 values in the
 /// specified arguments.  If we can't run cpuid on the host, return true.
-static inline bool GetCpuIDAndInfo(unsigned value, unsigned *rEAX,
-                                   unsigned *rEBX, unsigned *rECX,
-                                   unsigned *rEDX) {
+bool X86::GetCpuIDAndInfo(unsigned value, unsigned *rEAX, unsigned *rEBX,
+                          unsigned *rECX, unsigned *rEDX) {
 #if defined(__x86_64__)
-  asm ("pushq\t%%rbx\n\t"
-       "cpuid\n\t"
+  unsigned long long saveRBX;
+  asm ("nop" : "=b" (saveRBX));
+  asm ("cpuid\n\t"
        "movl\t%%ebx, %%esi\n\t"
-       "popq\t%%rbx"
        : "=a" (*rEAX),
          "=S" (*rEBX),
          "=c" (*rECX),
          "=d" (*rEDX)
        :  "a" (value));
+  asm ("nop" :: "b" (saveRBX));
   return false;
 #elif defined(i386) || defined(__i386__) || defined(__x86__) || defined(_M_IX86)
 #if defined(__GNUC__)
@@ -80,30 +81,30 @@
     char     c[12];
   } text;
 
-  if (GetCpuIDAndInfo(0, &EAX, text.u+0, text.u+2, text.u+1))
+  if (X86::GetCpuIDAndInfo(0, &EAX, text.u+0, text.u+2, text.u+1))
     return;
 
   // FIXME: support for AMD family of processors.
   if (memcmp(text.c, "GenuineIntel", 12) == 0) {
-    GetCpuIDAndInfo(0x1, &EAX, &EBX, &ECX, &EDX);
+    X86::GetCpuIDAndInfo(0x1, &EAX, &EBX, &ECX, &EDX);
 
     if ((EDX >> 23) & 0x1) X86SSELevel = MMX;
     if ((EDX >> 25) & 0x1) X86SSELevel = SSE1;
     if ((EDX >> 26) & 0x1) X86SSELevel = SSE2;
     if (ECX & 0x1)         X86SSELevel = SSE3;
 
-    GetCpuIDAndInfo(0x80000001, &EAX, &EBX, &ECX, &EDX);
+    X86::GetCpuIDAndInfo(0x80000001, &EAX, &EBX, &ECX, &EDX);
     HasX86_64 = (EDX >> 29) & 0x1;
   }
 }
 
 static const char *GetCurrentX86CPU() {
   unsigned EAX = 0, EBX = 0, ECX = 0, EDX = 0;
-  if (GetCpuIDAndInfo(0x1, &EAX, &EBX, &ECX, &EDX))
+  if (X86::GetCpuIDAndInfo(0x1, &EAX, &EBX, &ECX, &EDX))
     return "generic";
   unsigned Family  = (EAX >> 8) & 0xf; // Bits 8 - 11
   unsigned Model   = (EAX >> 4) & 0xf; // Bits 4 - 7
-  GetCpuIDAndInfo(0x80000001, &EAX, &EBX, &ECX, &EDX);
+  X86::GetCpuIDAndInfo(0x80000001, &EAX, &EBX, &ECX, &EDX);
   bool Em64T = (EDX >> 29) & 0x1;
 
   union {
@@ -111,7 +112,7 @@
     char     c[12];
   } text;
 
-  GetCpuIDAndInfo(0, &EAX, text.u+0, text.u+2, text.u+1);
+  X86::GetCpuIDAndInfo(0, &EAX, text.u+0, text.u+2, text.u+1);
   if (memcmp(text.c, "GenuineIntel", 12) == 0) {
     switch (Family) {
       case 3:


Index: llvm/lib/Target/X86/X86Subtarget.h
diff -u llvm/lib/Target/X86/X86Subtarget.h:1.19 llvm/lib/Target/X86/X86Subtarget.h:1.20
--- llvm/lib/Target/X86/X86Subtarget.h:1.19	Fri Oct  6 04:17:41 2006
+++ llvm/lib/Target/X86/X86Subtarget.h	Mon Oct 16 16:00:37 2006
@@ -106,6 +106,14 @@
   bool isTargetWindows() const { return TargetType == isWindows; }
   bool isTargetCygwin() const { return TargetType == isCygwin; }  
 };
+
+namespace X86 {
+  /// GetCpuIDAndInfo - Execute the specified cpuid and return the 4 values in
+  /// the specified arguments.  If we can't run cpuid on the host, return true.
+  bool GetCpuIDAndInfo(unsigned value, unsigned *rEAX, unsigned *rEBX,
+                       unsigned *rECX, unsigned *rEDX);
+}
+
 } // End llvm namespace
 
 #endif